fix(config): vite.config.ts can't import untranspiled ts files from other packages in the same monorepo (#5370) #18146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther packages in the same monorepo (vitejs#5370)
|
|
Open
7 tasks
ferferga
reviewed
Sep 19, 2024
| @@ -1641,6 +1641,10 @@ async function bundleConfigFile( | |||
| } | |||
| throw e | |||
| } | |||
| // not nod_modules dependency, compile it #5370 | |||
There was a problem hiding this comment.
Suggested change
| // not nod_modules dependency, compile it #5370 | |
| // not node_modules dependency, compile it #5370 |
Sorry, my English is not good, I don't quite understand what you said. I think this submission should have nothing to do with the suffix name, it just determines whether the file path contains node_modules, so you said, I can't think of what the relationship between them is, and it may be because I don't know the vite source code deeply enough. |
|
The similar idea is already suggested in a different PR #17323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(config): vite.config.ts can't import untranspiled ts files from other packages in the same monorepo (#5370)
Description
vite.config.ts support ts files from other packages in the same monorepo
If the file path contains node_modules, the file will not be compiled. If it does not contain node_modules, it means the local path, so it will be compiled.