Feature/G9_Driver #16
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like |
…M_dashboard into feature/G9Driversim
… mock_data test changes
mslaffin
commented
Oct 31, 2024
Comment on lines
+25
to
+31
| def handle_errors(self, data): | ||
| try: | ||
| response = g9_driv.read_response() | ||
| return {"status":"passes", "message":"No errors thrown at this time."} | ||
|
|
||
| except ValueError as e: | ||
| return {"status":"error", "message":str(e)} |
There was a problem hiding this comment.
This is being defined outside the class (self makes no sense as a param) and not used. I think this should be deleted and implement error handling directly in update_data
mslaffin
commented
Oct 31, 2024
| def update_interlock(self, name, safety, data): | ||
| # means good | ||
| if safety & data == 1: |
There was a problem hiding this comment.
I think there's an issue with this logic here. The == operator has higher precedence than & so this is evaluated as safety & (data == 1) not (safety & data) == 1 (which is how I think it should be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this for discussion of initial work on G9 driver code.