-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ingest2metrics #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two issues need correcting:
- please remove
print()
statements frompython/nistoar/rmm/mongo/nerdm.py
. These will not get captured by any log, and they crowd out other useful info in the unit test output. - the unit test,
python/tests/nistoar/rmm/mongo/test_nerdm.py
is failing, and it seems to be for a real reason: thepdrid
property is not getting set in thefileMetrices
record.
The complaint of the unit test is as follows:
======================================================================
FAIL: test_init_metrics_for (__main__.TestNERDmLoader)
----------------------------------------------------------------------
Traceback (most recent call last):
File "python/tests/nistoar/rmm/mongo/test_nerdm.py", line 201, in test_init_metrics_for
self.assertEqual(c[0]['pdrid'], 'ark:/88434/mds2-2106')
AssertionError: None != 'ark:/88434/mds2-2106'
----------------------------------------------------------------------
(To run the unit tests via docker, type scripts/testall.docker
. You may need to recreate the test container via docker/dockbuild.sh
. See repo's README.md
for more information.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tested this on testdata. Thanks for the updates and the testing!
No description provided.