Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettify list encoding #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcbrockschmidt
Copy link

@jcbrockschmidt jcbrockschmidt commented Jan 20, 2021

More closely match official TOML examples for arrays by excluding trailing commas.

For example, the return value for
print(toml.dumps({"data": [1, 2, 3, "abc"]}))
that used to be
data = [ 1, 2, 3, "abc",]
will now be
data = [ 1, 2, 3, "abc" ]

Change also makes dump_list more Pythonic.

More closely match official TOML examples for lists by excluding
trailing commas.
@codecov-io
Copy link

codecov-io commented Jan 20, 2021

Codecov Report

Merging #349 (99d17a2) into master (3f637db) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #349      +/-   ##
==========================================
- Coverage   89.74%   89.73%   -0.01%     
==========================================
  Files           5        5              
  Lines        1063     1062       -1     
==========================================
- Hits          954      953       -1     
  Misses        109      109              
Impacted Files Coverage Δ
toml/encoder.py 88.26% <100.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f637db...99d17a2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants