Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unify update/install/open and use YaruSplitButton #1845

Merged
merged 8 commits into from
Oct 16, 2024

Conversation

spydon
Copy link
Collaborator

@spydon spydon commented Oct 14, 2024

Screencast.from.2024-10-14.10-50-44.webm
  • Alignment of some context menues are still a bit off when it has extra space.
  • We shouldn't merge this until a new yaru version is released.

@spydon spydon marked this pull request as ready for review October 15, 2024 14:04
@spydon spydon requested a review from d-loose October 15, 2024 14:04
yaru:
git:
url: https://github.com/ubuntu/yaru.dart.git
ref: main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the alignment fix is in we'll do a release that we can depend on.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the yaru version is released, so I'm merging :)

Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, LGTM!
Could we wait until a new yaru version is released before merging this, to not depend on yaru's main branch?

@spydon
Copy link
Collaborator Author

spydon commented Oct 16, 2024

Great work, LGTM!
Could we wait until a new yaru version is released before merging this, to not depend on yaru's main branch?

That's the plan, we're doing the Yaru release now :)

@spydon spydon merged commit 460a05a into main Oct 16, 2024
4 checks passed
@spydon spydon deleted the feat/use-split-button branch October 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants