Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support to 'plugin' package #1633

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Raiane-Dev
Copy link

for cases where we have package import errors, it is good to have the option to link a plugin that contains these libraries.

@CLAassistant
Copy link

CLAassistant commented May 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@mvertes mvertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this first contribution! In fact, to add a new generated wrapper, you need to do the following:

  • edit the file listing the wrappers to be generated, and add the missing plugin name to it, for example at
    //go:generate ../internal/cmd/extract/extract path path/filepath reflect regexp regexp/syntax
  • from project root, run make generate with go version go1.22
  • make generate again with go version go1.21

You should obtain new generated files stdlib/go1_21_plugin.go and stdlib/go1_22_plugin.go.

The pull request should contain patches to stdlib/stdlib.go, and the generated files.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants