Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(merge): Handle edge-case for merge #556

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mass2527
Copy link
Contributor

@mass2527 mass2527 commented Sep 19, 2024

I understood how the merge function works by testing Lodash's merge function. I then realized there was a difference between the two.

Although this is not compat/merge, the behavior should be consistent. Please let me know if the current behavior is intended.

Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
es-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 5:13am

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.24%. Comparing base (fd119dd) to head (2443872).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   99.29%   99.24%   -0.06%     
==========================================
  Files         228      228              
  Lines        1989     1989              
  Branches      550      550              
==========================================
- Hits         1975     1974       -1     
- Misses         13       14       +1     
  Partials        1        1              

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants