Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve 01_concepts #1221

Merged
merged 2 commits into from
Oct 10, 2024
Merged

docs: Improve 01_concepts #1221

merged 2 commits into from
Oct 10, 2024

Conversation

strakam
Copy link
Contributor

@strakam strakam commented Oct 10, 2024

  • fix logical error for done
  • add references to issues
  • make some parts of the document more visually pleasing

idk how to add label :(

  • I have added the correct label(s) to this Pull Request or linked the relevant issue(s)
  • I have provided a description of the changes in this Pull Request
  • I have added documentation for my changes and have listed relevant changes in CHANGELOG.md
  • If applicable, I have added tests to cover my changes.
  • I have reformatted the code using poe format
  • I have checked style and types with poe lint and poe type-check
  • (Optional) I ran tests locally with poe test
    (or a subset of them with poe test-reduced) ,and they pass
  • (Optional) I have tested that documentation builds correctly with poe doc-build

- fix logical error for `done`
- add references to issues
- make some parts of the document more visually pleasing
@Trinkle23897 Trinkle23897 enabled auto-merge (squash) October 10, 2024 20:21
@Trinkle23897 Trinkle23897 merged commit 2154065 into thu-ml:master Oct 10, 2024
4 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (16f2fc2) to head (35c4cee).
Report is 4 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1221      +/-   ##
==========================================
- Coverage   85.29%   85.28%   -0.02%     
==========================================
  Files         102      102              
  Lines        9078     9078              
==========================================
- Hits         7743     7742       -1     
- Misses       1335     1336       +1     
Flag Coverage Δ
unittests 85.28% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants