Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with thumbor.filters.fill #24

Merged
merged 3 commits into from
Jul 7, 2024

Conversation

fdintino
Copy link
Member

@fdintino fdintino commented Jul 3, 2024

fixes #12

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (357ba2d) to head (37d8972).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   95.72%   95.74%   +0.01%     
==========================================
  Files          17       17              
  Lines         865      869       +4     
  Branches      179      180       +1     
==========================================
+ Hits          828      832       +4     
  Misses         29       29              
  Partials        8        8              
Files Coverage Δ
src/thumbor_video_engine/engines/video.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 357ba2d...37d8972. Read the comment docs.

Copy link

github-actions bot commented Jul 3, 2024

Unit Test Results

    6 files  ±0      6 suites  ±0   2m 48s ⏱️ +4s
  187 tests +1    187 ✅ +1   0 💤 ±0  0 ❌ ±0 
1 108 runs  +6  1 046 ✅ +6  62 💤 ±0  0 ❌ ±0 

Results for commit 37d8972. ± Comparison against base commit 357ba2d.

♻️ This comment has been updated with latest results.

@fdintino fdintino force-pushed the fix/thumbor-fill-filter branch 3 times, most recently from 528bce5 to 417f617 Compare July 5, 2024 15:14
@fdintino fdintino force-pushed the fix/thumbor-fill-filter branch 2 times, most recently from 4c1bc0d to 47603ca Compare July 5, 2024 19:23
@fdintino fdintino marked this pull request as ready for review July 7, 2024 17:54
@fdintino fdintino merged commit 5e44c0c into main Jul 7, 2024
9 checks passed
@fdintino fdintino deleted the fix/thumbor-fill-filter branch July 7, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with thumbor.filters.fill
2 participants