Handle pinch-in/pinch-out on a Mac trackpad #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theKashey
reviewed
Aug 30, 2024
| @@ -54,7 +54,7 @@ export function RemoveScrollSideCar(props: IRemoveScrollEffectProps) { | |||
| }, [props.inert, props.lockRef.current, props.shards]); | |||
|
|
|||
| const shouldCancelEvent = React.useCallback((event: WheelEvent | TouchEvent, parent: HTMLElement) => { | |||
| if ('touches' in event && event.touches.length === 2) { | |||
| if (('touches' in event && event.touches.length === 2) || (event.type === 'wheel' && event.ctrlKey)) { | |||
There was a problem hiding this comment.
what wheel + ctrlKey means?
I am trying this combination and it does nothing.
There was a problem hiding this comment.
...as they enabled pinch-to-zoom gestures from multi-touch trackpad’s to be surfaced as mousewheelevent with the ctrlmodifier set to true...
- https://kenneth.io/post/detecting-multi-touch-trackpad-gestures-in-javascript
- Pinch zoom does not work on MacOS when content is not scrollable or content is at
scrollTop0 #75 (comment) - [Dialog] Unable to pinch zoom using trackpad radix-ui/primitives#1554 (comment)
This is how pinch to zoom works in desktop browsers 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for pinch-out pinch-in operation with the Mac trackpad.
It relates to the following issues.
scrollTop0 #75It also affects shadcn/ui, which uses radix-ui internally.