-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Bootstrap theme to modern syntax #5191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inikolova
force-pushed
the
bootstrap-dart
branch
3 times, most recently
from
October 14, 2024 15:58
4fbb88d
to
3ac05af
Compare
zhpenkov
force-pushed
the
bootstrap-dart
branch
from
October 15, 2024 07:34
248aad5
to
d1e6ea0
Compare
epetrow
force-pushed
the
core-utils-dart
branch
from
October 15, 2024 11:54
f89da71
to
c0669b9
Compare
inikolova
force-pushed
the
bootstrap-dart
branch
from
October 16, 2024 08:58
db841ff
to
8bb6f0b
Compare
epetrow
force-pushed
the
core-utils-dart
branch
from
October 16, 2024 09:00
d7406af
to
29c69c8
Compare
inikolova
force-pushed
the
bootstrap-dart
branch
3 times, most recently
from
October 17, 2024 11:57
bf917d8
to
e02cc10
Compare
epetrow
force-pushed
the
core-utils-dart
branch
8 times, most recently
from
October 18, 2024 07:11
a7cb324
to
6580397
Compare
inikolova
force-pushed
the
bootstrap-dart
branch
11 times, most recently
from
October 22, 2024 13:25
83b9fee
to
67060c6
Compare
inikolova
force-pushed
the
bootstrap-dart
branch
2 times, most recently
from
October 31, 2024 08:45
d7a1237
to
96e40d0
Compare
silviyaboteva
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great output! 👏🏻❤️
I only suggest to fixup the commits a bit :)
inikolova
force-pushed
the
bootstrap-dart
branch
from
October 31, 2024 08:54
0045df3
to
04a38ce
Compare
zhpenkov
reviewed
Oct 31, 2024
zhpenkov
reviewed
Oct 31, 2024
zhpenkov
reviewed
Oct 31, 2024
zhpenkov
reviewed
Oct 31, 2024
inikolova
force-pushed
the
bootstrap-dart
branch
from
October 31, 2024 09:43
61fd4fa
to
c5edee3
Compare
epetrow
force-pushed
the
core-utils-dart
branch
2 times, most recently
from
October 31, 2024 13:00
09f01f5
to
23f3d7c
Compare
inikolova
force-pushed
the
bootstrap-dart
branch
2 times, most recently
from
October 31, 2024 13:43
89aa62c
to
b54ca6b
Compare
epetrow
force-pushed
the
core-utils-dart
branch
from
October 31, 2024 13:45
23f3d7c
to
cefa2e8
Compare
inikolova
force-pushed
the
bootstrap-dart
branch
from
October 31, 2024 14:34
ad2b0a2
to
8ff74d1
Compare
zhpenkov
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
inikolova
force-pushed
the
bootstrap-dart
branch
4 times, most recently
from
October 31, 2024 14:58
03c4b21
to
be315c1
Compare
BREAKING CHANGE Starting with the R4 2024 release, all Kendo themes are now migrated to the SASS module system. This breaking change is due to the `node-sass` package reaching its official end of life. For more information, please refer to the following links: * https://sass-lang.com/blog/the-module-system-is-launched/ * sass/node-sass@107ded9
BREAKING CHANGE: Effective with the R4 2024 release, twbs/bootstrap is removed as a dependency of the Kendo UI Bootstrap theme. This means that customizing bootstrap scss variables will no longer have an effect on our components, as the theme will be detached i.e. not depending upon. However, we will provide mostly the same look and feel through variables that have the same values. In order to continue using twbs/bootstrap along with the Kendo Bootstrap theme, make sure to add a it as a dependency to your project.
inikolova
force-pushed
the
bootstrap-dart
branch
from
October 31, 2024 15:18
be315c1
to
49a85a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/telerik/kendo-themes-private/issues/273