KB Grid handle empty popup footer #2445
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added new kb article grid-handle-empty-popup-footer * chore(Grid): polish article and add links * Update knowledge-base/grid-handle-empty-popup-footer.md Co-authored-by: Yordan <[email protected]> * Update knowledge-base/grid-handle-empty-popup-footer.md Co-authored-by: Yordan <[email protected]> * Update knowledge-base/grid-handle-empty-popup-footer.md --------- Co-authored-by: KB Bot <[email protected]> Co-authored-by: Nadezhda Tacheva <[email protected]> Co-authored-by: Nadezhda Tacheva <[email protected]> Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
Co-authored-by: Yordan <[email protected]>
dimodi
reviewed
Oct 24, 2024
dimodi
reviewed
Oct 24, 2024
dimodi
reviewed
Oct 24, 2024
Comment on lines
+39
to
+42
| * [Option 1: Display Custom Buttons in the Footer](#option-1-display-custom-buttons-in-the-footer) | ||
| * [Option 2: Remove the Footer and Keep the Buttons in the FormTemplate](#option-2-remove-the-footer-and-keep-the-buttons-in-the-formtemplate) | ||
|
|
||
| ### Option 1: Display Custom Buttons in the Footer |
dimodi
reviewed
Oct 24, 2024
Comment on lines
+133
to
+154
| public List<Person> People | ||
| { | ||
| get | ||
| { | ||
| if (_people == null) | ||
| { | ||
| _people = GeneratePeople(30); | ||
| } | ||
|
|
||
| return _people; | ||
| } | ||
| } | ||
|
|
||
| protected override void OnInitialized() | ||
| { | ||
| LoadData(); | ||
| } | ||
|
|
||
| private void LoadData() | ||
| { | ||
| GridData = GetPeople(); | ||
| } |
There was a problem hiding this comment.
This looks over-engineered. Why not generate the data in OnInitialized and forget about it?
dimodi
approved these changes
Oct 24, 2024
Co-authored-by: Dimo Dimov <[email protected]>
Co-authored-by: Dimo Dimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.