Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat add immediately opt for repeat #536

Merged

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented May 8, 2021

This PR allows us to create a repeated job that will be executed immediately. Reference OptimalBits/bull#1422

@manast
Copy link
Contributor

manast commented May 17, 2021

There is a small consideration here, and is that when using immediately, the next iteration would occur most certainly too soon. So in order to make it work perfectly we would need to store some offset that we need to apply in every iteration. This offset would be the difference between the current timestamp and the timestamp where we actually would have executed the job if we did not use "immediately".

@roggervalf
Copy link
Collaborator Author

There is a small consideration here, and is that when using immediately, the next iteration would occur most certainly too soon. So in order to make it work perfectly we would need to store some offset that we need to apply in every iteration. This offset would be the difference between the current timestamp and the timestamp where we actually would have executed the job if we did not use "immediately".

Let me think a little bit how to address this

@manast
Copy link
Contributor

manast commented May 24, 2021

excellent!.

@manast manast merged commit d095573 into taskforcesh:master May 24, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@roggervalf roggervalf deleted the feat-add-immediately-opt-for-repeat branch May 24, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants