Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors #308

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Fix errors #308

merged 2 commits into from
Jul 17, 2024

Conversation

kearfy
Copy link
Member

@kearfy kearfy commented Jul 17, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

convertAuth threw an error if a namespace was specified, while database was omitted.

What does this change do?

It makes database optional, and additionally some generic Error instances are now converted to SurrealDbError

What is your testing strategy?

Added a test for convertAuth

Is this related to any issues?

No

Have you read the Contributing Guidelines?

@kearfy kearfy merged commit 2a8f5c2 into main Jul 17, 2024
8 checks passed
@kearfy kearfy deleted the micha/fix-errors branch July 17, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant