Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build #306

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Fix build #306

merged 2 commits into from
Jul 12, 2024

Conversation

kearfy
Copy link
Member

@kearfy kearfy commented Jul 12, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What is the motivation?

The build script would silently fail on dts compilation error

What does this change do?

Fixes the ts error and ensures that the build script fails on error

What is your testing strategy?

GitHub CI

Is this related to any issues?

No

Have you read the Contributing Guidelines?

@kearfy kearfy merged commit d645048 into main Jul 12, 2024
8 checks passed
@kearfy kearfy deleted the micha/fix-build branch July 12, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant