-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Knip with initial custom config #29111
base: next
Are you sure you want to change the base?
Conversation
Initial results are lengthy but useful. Took quite a few samples and this list is actionable if you'd ask me. What do you think? Should the issues be dealt with in this PR too? Perhaps that's a bit much, but let's discuss. Here's the starting point: Unused files (25)
Unused dependencies (152)
Unused devDependencies (42)
Referenced optional peerDependencies (6)
Unlisted dependencies (28)
Unlisted binaries (71)
Unresolved imports (9)
Unused exports (275)
Unused exported types (146)
Unused exported enum members (8)
Duplicate exports (4)
|
Going to make a new "github-collapsible" reporter for output like this btw 😅 |
1511e46
to
9f15da5
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9f15da5. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Damn that's a lot of dirt to cleanup! 😅 I can't verify all of it, but a big portion of this looks good and really useful list!
|
Closes #29106
What I did
package.json#bundler
entries as entry pathsChecklist for Contributors
Manual testing
Documentation
N/A?
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>