feat: add C implementation for blas/base/ssyr
#2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdlib-bot
added
the
BLAS
kgryte
added
Needs Review
kgryte
reviewed
Sep 7, 2024
kgryte
reviewed
Sep 21, 2024
|
|
||
| ```c | ||
| TODO | ||
| void c_ssyr( const CBLAS_LAYOUT order, const CBLAS_UPLO uplo, const CBLAS_INT N, const float alpha, float *X, const CBLAS_INT strideX, float *A, const CBLAS_INT LDA ) |
There was a problem hiding this comment.
Suggested change
| void c_ssyr( const CBLAS_LAYOUT order, const CBLAS_UPLO uplo, const CBLAS_INT N, const float alpha, float *X, const CBLAS_INT strideX, float *A, const CBLAS_INT LDA ) | |
| void c_ssyr( const CBLAS_LAYOUT order, const CBLAS_UPLO uplo, const CBLAS_INT N, const float alpha, const float *X, const CBLAS_INT strideX, float *A, const CBLAS_INT LDA ) |
|
|
||
| ```c | ||
| TODO | ||
| void c_ssyr( const CBLAS_LAYOUT order, const CBLAS_UPLO uplo, const CBLAS_INT N, const float alpha, float *X, const CBLAS_INT strideX, float *A, const CBLAS_INT LDA ) | ||
| ``` | ||
|
|
There was a problem hiding this comment.
@aman-095 Looks like we still need to add the ndarray API docs, correct?
kgryte
added
Needs Changes
kgryte
reviewed
Sep 21, 2024
| float A[] = { 1.0f, 0.0f, 0.0f, 2.0f, 1.0f, 0.0f, 3.0f, 2.0f, 1.0f }; | ||
| float x[] = { 1.0f, 2.0f, 3.0f }; | ||
|
|
||
| c_ssyr( 102, 121, 3, 1.0f, x, 1, A, 3 ); |
There was a problem hiding this comment.
Do not hardcode enum values. Use enum identifiers. The values are subject to change. Enums should be treated as opaque constants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progresses #2039.
Description
This pull request proposes to add C implementation for
blas/base/ssyr.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers