Merge pull request #510 from stan-dev/bugfix/issue-497-offset-multiplier

Fix the offset without multiplier or multiplier without offset bug
stan-dev · Apr 19, 2020 · f556d0d · f556d0d
2 parents 1e4c2fb + 034a7dd
commit f556d0d
Show file tree

Hide file tree

Showing 4 changed files with 2,116 additions and 1,589 deletions.
diff --git a/src/frontend/Ast_to_Mir.ml b/src/frontend/Ast_to_Mir.ml
@@ -257,8 +257,8 @@ let constraint_forl = function
 
 let extract_transform_args = function
   | Program.Lower a | Upper a -> [a]
-  | Offset a -> [{a with Expr.Fixed.pattern= Lit (Int, "0")}; a]
-  | Multiplier a -> [a; {a with pattern= Lit (Int, "1")}]
+  | Offset a -> [a; {a with Expr.Fixed.pattern= Lit (Int, "1")}]
+  | Multiplier a -> [{a with pattern= Lit (Int, "0")}; a]
   | LowerUpper (a1, a2) | OffsetMultiplier (a1, a2) -> [a1; a2]
   | Covariance | Correlation | CholeskyCov | CholeskyCorr | Ordered
    |PositiveOrdered | Simplex | UnitVector | Identity ->