-
-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
avoid redundant computations by moving `sqrt(srs_diffe$v_y_hat + srs_…
…diffe$hat_v_y)` into `.srs_diff_est_w()`
- Loading branch information
Showing
1 changed file
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2727cff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit makes the
.srs_diff_est_w(()
to have different behavior from the one inloo
package, so the name of the function should be changed and a comment should be added that the extra line is changing the behavior compared to the original paper, too. Alternatively, revert this commit and keep that combination of variances where it was.2727cff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, I wasn't aware of the connection with the loo package. I've reverted this in commit 348827c.