Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start documentation of sum_to_zero_vector #818

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

WardBrian
Copy link
Member

Submission Checklist

  • Builds locally
  • New functions marked with <<{ since VERSION }>>
  • Declare copyright holder and open-source license: see below

Summary

Closes #804.

I think I need some help from @spinkney @bob-carpenter filling out the documentation of the specific transform, see the two "TODO:" lines in transforms.qmd

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@spinkney
Copy link
Collaborator

I'll try and take a look this week

@bob-carpenter
Copy link
Contributor

I can take a shot at this, @spinkney. I think the definition is clear enough.

@bob-carpenter
Copy link
Contributor

I have most of this written up and just have to double check. I should be able to push the doc tomorrow (Wednesday). I'm just transating from the code. It's really nice that there's no Jacobian adjustment.

@bob-carpenter
Copy link
Contributor

I wrote out the math for the transform. It'd be great if @spinkney could review, though I'm pretty sure it at least matches the code as is (perhaps modulo a +1 or -1 on indexing, but I triple-checked all that, too).

@bob-carpenter bob-carpenter marked this pull request as ready for review October 4, 2024 21:25
@WardBrian
Copy link
Member Author

@spinkney do you think you will have a chance to look at this?

@spinkney
Copy link
Collaborator

@spinkney do you think you will have a chance to look at this?

When is the deadline?

@WardBrian
Copy link
Member Author

The 11th, unless we end up delaying the release again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document sum_to_zero_vector
3 participants