Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorized complex accessors #685

Closed
wants to merge 1 commit into from
Closed

Conversation

bob-carpenter
Copy link
Contributor

Description

Adds vectorized signature doc for complex accessors.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter bob-carpenter added the enhancement New feature or request label Nov 1, 2023
@bob-carpenter
Copy link
Contributor Author

Can someone please review and merge this? Thanks.

@WardBrian
Copy link
Member

This as written leads to duplication with the later section on matrices, as I pointed out here: #684 (comment)

@bob-carpenter
Copy link
Contributor Author

Thanks for the reminder. Should we put a link in instead? I'm worried that people will find the scalar function and then not realize it can take more arguments. Somehow, I'd like to keep all the doc for a single function name together to the extent possible. This makes me realize we haven't done this elsewhere.

@WardBrian
Copy link
Member

I think a link seems reasonable? I believe having the information in both sections makes sense, but the existing page has a bunch of exposition that is good to not duplicate.

We definitely have some mixed conventions here, but I think the original discoverability issue would be solved by a link on the scalar version's page

@bob-carpenter
Copy link
Contributor Author

This is the tip of a much larger iceberg of problems that need to be solved in more generality, so I'm closing this little PR.

@WardBrian WardBrian deleted the complex-accessor-vec branch March 5, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants