Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complex accessor vectorization #684

Open
spinkney opened this issue Nov 1, 2023 · 3 comments
Open

Complex accessor vectorization #684

spinkney opened this issue Nov 1, 2023 · 3 comments

Comments

@spinkney
Copy link
Collaborator

spinkney commented Nov 1, 2023

Complex accessors are vectorized but documentation just shows that the output is a real.

https://mc-stan.org/docs/functions-reference/complex-constructors.html#complex-accessors

@bob-carpenter
Copy link
Contributor

OK, I'll submit a patch for this now.

@WardBrian
Copy link
Member

The vectorized versions are currently documented elsewhere: https://mc-stan.org/docs/functions-reference/vectorized-accessor-functions.html#real-and-imaginary-component-accessor-functions

We could unify these, but there's a bit of extra explanation on the types that is nice to call out

@bob-carpenter
Copy link
Contributor

I'd be in favor of combining them or at least cross-referencing. There's also the issue of any downstream tools. I hadn't thought that through using complexes and reals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants