Add option to keep object file after compiling model #1186
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
This PR adds a makeflag
KEEP_OBJECT
to allow keeping the.o
object file when compiling a model.When exposing model methods (
log_prob
, etc) incmdstanr
we end up having to compile a given model twice - once viacmdstan
to generate the executable and once via Rcpp to expose thestan_model
typedef to generate a model pointer. If we can still have access to the object file, we can instead just link against it and skip the additional compilation.Intended Effect:
Reduce unnecessary compilation when exposing model methods in
cmdstanr
How to Verify:
Add
KEEP_OBJECT=true
tomake/local
Side Effects:
N/A
Documentation:
N/A
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: