Sound driver and other documentation updates and fixes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working towards [sonicretro#32](sonicretro#32); thankfully, it's close enough to Sonic 1's code that I can take names from the S1 disassembly. Some comments have been changed accordingly. I also fixed a few typos and inconsistent tab character uses, as well as converted all uses of "branch" to "jump" to better reflect Z80 assembly nomenclature.
A more liberal take on things: some names have been replaced or reverted, based on feedback from my last commit. Other things: I completely redid one comment for clarity's sake (since there was misleading information)... and I noticed this last time, but only saw fit to mention it now: there's a line that was changed between 1 and 2 that I don't know if this is a bug. Perhaps someone more knowledgable can clue me in?
Some more stuff changed to either a) reflect information gained from the released SMPS source code, b) make things a bit more person-neutral. and c) fill in the last remaining zloc-ed names.
After over a decade, every label should now have been changed from the default "zloc" style labels. All three version build bit-perfect.
The war (on nameless temporary labels) began, Earth trembling in fear
flamewing
requested changes
Nov 20, 2021
Yes, these genuinely ARE out of order in the code. The order has been reversed to match both the Sonic 1 disassembly and the SMPS 68K source code release from Hidden Palace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to work on #32, several edits have been made to do the following:
Many of the labels I added were taken from the Sonic 1 disassembly.