Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PanModalPresentationController's methods open so they can be overriden by a subclass #181

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bartosz-treeline
Copy link

Summary

Let's say I want to create a presentation controller that has a similar behaviour as PanModalPresentationController. I want to be able to create a PanModalPresentationController's subclass and make some adjustments.
For example I want to create a DrawerPresentationController that inherits from PanModalPresentationController and override containerViewWillLayoutSubviews in order to be able to add more views to the container (e.g. close button that closes a drawer once tapped).

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • I've read and agree to the Code of Conduct.

  • I've written tests to cover the new code and functionality included in this PR.

@CLAassistant
Copy link

CLAassistant commented May 23, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants