Update animations to use UIViewPropertyAnimator #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kyle Bashour seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kylebshr
commented
Feb 21, 2021
| @@ -65,4 +65,10 @@ class AlertViewController: UIViewController, PanModalPresentable { | |||
| var isUserInteractionEnabled: Bool { | |||
| return true | |||
| } | |||
|
|
|||
| func makeAnimator() -> UIViewPropertyAnimator { | |||
| let animator = UIViewPropertyAnimator(duration: 0.5, dampingRatio: 0.7, animations: nil) | |||
There was a problem hiding this comment.
I think notifications are a great place for springy animations, and provided an example of a custom animator there.
|
I really like this PR. Is this still applicable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR has a couple goals:
UIViewPropertyAnimatorrather than properties that are provided toUIView.animateBoth of these are accomplished by using a
UIViewPropertyAnimatorfor animation transitions. I thought about how to model this for a while, and I think the solution I implemented works best with the current API design ofPanModal. I introduced a new function onPanModalPresentable:func makeAnimator() -> UIViewPropertyAnimator. This is a function becauseUIViewPropertyAnimatoris stateful, so a new one should be created for each animation. I avoided adding a delegate method to perform the animations because that is prone to user error, e.g., not calling the completion block. The default implementation creates an animator with the defaultUISpringTimingParameters, which matches the animation used to present modals in iOS (https://twitter.com/smileyborg/status/745310304481906688).RE: tests - there weren't any animation tests to improve upon. I'm happy to add some if the maintainers have any thoughts on what to test.
Fixes #133
Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.