Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make userInterfaceIdiom injectable on presentPanModal(_:) #128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stleamist
Copy link

@stleamist stleamist commented Jan 12, 2021

Summary

Make userInterfaceIdiom injectable on presentPanModal(_:).
This allows users to present a PanModal without using .popover style on the iPadOS.

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • I've read and agree to the Code of Conduct.

  • I've written tests to cover the new code and functionality included in this PR.

@stleamist stleamist changed the title Make userInterfaceIdiom injectable on presentPanModal(_: Make userInterfaceIdiom injectable on presentPanModal(_:) Jan 12, 2021
@KacperCzapp
Copy link

I'd like also to have this, I'm using a "popover-like" ui on an iPad and I cannot display it in the native popover, but to behave the same as on iPhones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants