Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Fix 3D/4D cases with core 2.27 #3268

Merged
merged 2 commits into from
Oct 31, 2024
Merged

[python] Fix 3D/4D cases with core 2.27 #3268

merged 2 commits into from
Oct 31, 2024

Conversation

johnkerl
Copy link
Member

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Fixes another core 2.27 corner case, aside from the main case on #3263.

Notes for Reviewer:

Copy link
Member

@nguyenv nguyenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating it out

Base automatically changed from kerl/dense-range-trim to main October 31, 2024 20:59
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.91%. Comparing base (130ccc6) to head (7bbe40f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3268      +/-   ##
==========================================
+ Coverage   83.79%   83.91%   +0.12%     
==========================================
  Files          51       51              
  Lines        5567     5578      +11     
==========================================
+ Hits         4665     4681      +16     
+ Misses        902      897       -5     
Flag Coverage Δ
python 83.91% <90.90%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.91% <84.61%> (+0.12%) ⬆️
libtiledbsoma ∅ <ø> (∅)

@johnkerl johnkerl merged commit 945804c into main Oct 31, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/dim-explosion branch October 31, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants