Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] Bindings for upgrade_domain #3235

Merged
merged 4 commits into from
Oct 28, 2024
Merged

[python] Bindings for upgrade_domain #3235

merged 4 commits into from
Oct 28, 2024

Conversation

johnkerl
Copy link
Member

@johnkerl johnkerl commented Oct 24, 2024

Issue and/or context: As tracked on issue #2407 / [sc-51048].

Note that the intended Python and R API changes are all agreed on and finalized as described in #2407.

Changes:

Connects #3220 to the Python user-facing layers.

Notes for Reviewer:

I was going to do Python+R on a single PR but the line count is ~400 which is enough (IMO) so I'll make a separate for R -- cc @mojaveazure

@johnkerl johnkerl force-pushed the kerl/py-r-ugr-dom branch 3 times, most recently from 2de8c24 to 9ea23eb Compare October 24, 2024 16:45
@johnkerl johnkerl changed the base branch from kerl/docstring-prune to kerl/prefixing October 24, 2024 16:51
@johnkerl johnkerl changed the title [python/r] Bindings for upgrade_domain [python] Bindings for upgrade_domain Oct 24, 2024
@johnkerl johnkerl marked this pull request as ready for review October 24, 2024 18:30
@johnkerl johnkerl requested a review from nguyenv October 24, 2024 18:31
@johnkerl johnkerl marked this pull request as draft October 24, 2024 20:51
@johnkerl johnkerl requested review from nguyenv and removed request for nguyenv October 24, 2024 20:51
@johnkerl johnkerl marked this pull request as ready for review October 24, 2024 20:57
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 78.26087% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (3e20d3c) to head (b28d022).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3235      +/-   ##
==========================================
- Coverage   83.88%   83.84%   -0.05%     
==========================================
  Files          51       51              
  Lines        5512     5557      +45     
==========================================
+ Hits         4624     4659      +35     
- Misses        888      898      +10     
Flag Coverage Δ
python 83.84% <78.26%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
python_api 83.84% <78.26%> (-0.05%) ⬇️
libtiledbsoma ∅ <ø> (∅)

Base automatically changed from kerl/prefixing to main October 25, 2024 16:08
apis/python/src/tiledbsoma/_dataframe.py Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_dataframe.py Outdated Show resolved Hide resolved
libtiledbsoma/src/soma/soma_array.h Outdated Show resolved Hide resolved
libtiledbsoma/src/soma/soma_array.h Outdated Show resolved Hide resolved
apis/python/src/tiledbsoma/_dataframe.py Show resolved Hide resolved
@johnkerl johnkerl force-pushed the kerl/py-r-ugr-dom branch 4 times, most recently from 95182e3 to a59204c Compare October 27, 2024 02:01
@johnkerl
Copy link
Member Author

@nguyenv ready for next round!

@johnkerl johnkerl requested a review from nguyenv October 27, 2024 02:47
@johnkerl
Copy link
Member Author

Thanks @nguyenv !

@johnkerl johnkerl merged commit 24a7438 into main Oct 28, 2024
15 checks passed
@johnkerl johnkerl deleted the kerl/py-r-ugr-dom branch October 28, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants