-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python] Initial work toward PyTorch data loaders #2823
Conversation
…ed lint/formatting issues
…experimentdatapipe
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2823 +/- ##
===========================================
+ Coverage 61.10% 89.79% +28.69%
===========================================
Files 95 40 -55
Lines 12382 4096 -8286
Branches 781 0 -781
===========================================
- Hits 7566 3678 -3888
+ Misses 4625 418 -4207
+ Partials 191 0 -191
Flags with carried forward coverage won't be shown. Click here to find out more.
|
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
other_packages/python/tiledbsoma_ml/src/tiledbsoma_ml/pytorch.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. I'm excited to start testing it out. The docs are comprehensive and super clear. My suggested changes are largely minor typos and small improvements for clarity/consistency.
PR superceded by single-cell-data/TileDB-SOMA-ML#1 |
This PR is superceded by single-cell-data/TileDB-SOMA-ML#1 and is being closed. No further work will be done on this branch.
Notes to reviewers:
tutorial_pytorch.ipynb
) has been updated to run with all API modifications.This PR contains a PyTorch iterable-style DataSet/DataPipe for use with SOMA Experiment. Initial code contributed by the Chan Zuckerberg single-cell team. Modifications to the original code include:
tiledbsoma_ml
API change summary:
ExperimentAxisQuery
, rather than than anExperiment
Benchmarking results vs the
cellxgene-census
loader will be forthcoming shortly.