Exact: Fix usage with recursive types and unions
#949
Merged
+24
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abrenneke
force-pushed
the
abrenneke/exact-isequal
branch
2 times, most recently
from
ecbfeed
to
031bcf6
Compare
zorji
reviewed
Sep 7, 2024
test-d/exact.ts
Outdated
| // @see https://github.com/sindresorhus/type-fest/issues/948 | ||
| { | ||
| type A = { | ||
| a: A; |
There was a problem hiding this comment.
Sorry, I don't understand this type. Looks like this is an infinite recursive type.
Do you actually mean the following?
type A = {
a: Expected;
}
There was a problem hiding this comment.
Ah, yes I think that's what I meant
There was a problem hiding this comment.
Fixed. I think it would also test the same case with a?: A. As long as there's some sort of recursion in either of the types. TS doesn't even really care about the infinite recursion unless you try to actually instantiate or resolve the type 🤷
|
@abrenneke Sorry for the late reply. I think the implementation is OK but I have a question for the test case. |
abrenneke
force-pushed
the
abrenneke/exact-isequal
branch
from
031bcf6
to
7ebfa4a
Compare
zorji
approved these changes
Sep 8, 2024
sindresorhus
changed the title
Exact: Fix usage with recursive types and unions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #948
This moves
IsEqualto be the first check, before any distribution, restoring the behavior before #911.Wrote a test for it, and all tests are still passing, including those written for #911!