Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made some changes that pass more test cases than the current solution. I was heavily inspired by
CamelCase
implementationLet me know if this is something worth investing more time into or if I'm doing some basic mistake and butchering performance for example
Also, what should be the behavior of
string1
conversionhello123
- this is the current behaviorhello_123
- another valid behaviorcamelCase
- in that case there's still a question of what should be the default (most likelyhello123
for backwards compatibility)Opinions seem to be mixed from one library to another
Even more interestingly, those libraries that default to
hello_123
don't have an option to customize it, but those that default tohello123
have optional parameters to change thatRelated issues:
#223
#336
What I'd still like to add:
hello123
case and implement