-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add possibility to specify DL and UL chunk size #174
base: master
Are you sure you want to change the base?
feat: add possibility to specify DL and UL chunk size #174
Conversation
aea3200
to
4b67486
Compare
4b67486
to
ceca7ad
Compare
Thank you very much for your PR. Could you provide their experiental report? In fact, chunk size is only an approximate value which always less than the preset value(jpg images are compressed). So should it be marked with approximate value on tip? |
I observe significant improvement in results with 4k "size" for shitty linlks. Experiment 1:
Experiment 2:
On artificially degraded link with stable conditions, 4k version of |
@r3inbowari are there any chances to get this merged? |
Yes, we will merge it after vacation. |
Hi, @berezovskyi-oleksandr, I make a change to fix multi server test error. could you test it, if ok, we can merge it now. |
I'd like to be able to specify this as well. |
It might be crucial to have the possibility to configure the chunk sizes. I observed that in some cases chunk size impacts the results.