Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): update form values with name prop for React Hook Form compatibility (#2984) #4861

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

asadulloh-pro
Copy link

Description:

This pull request fixes a bug in the Select component example in the documentation where the React Hook Form's values were updating, but the form element’s actual values were not. As a result, form actions would fail because the form would not send those values.

To fix this, I added a name prop to the <Select> component, along with proper handlers to ensure the values are properly bound to the form:

<Select 
  name={field.name} 
  onValueChange={field.onChange} 
  defaultValue={field.value} 
/>

Copy link

vercel bot commented Sep 15, 2024

@asadulloh-pro is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant