-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NameService and NameProvider #425
base: master
Are you sure you want to change the base?
Conversation
This change allows to define a way to derive names from objects of third party libraries, e.g. for use in ObjectService, where objects are registered with a name and can be provided e.g. in a drop-down choice in the UI.
Hi @imagejan , Could this provide a mechanism to solve imagej/imagej-legacy#243 as well ? |
@NicoKiaru absolutely, it could solve the problem of having |
Then it could be adde in the ij1 macro engine I guess ? |
@NicoKiaru iff the change proposed here gets merged and included in a release, and then the change from The remaining issue would then be the other direction, determining the object from the given name, which is potentially ambiguous, but let's discuss this on the |
Getting a converter from String to an object can be handled quite correctly by converter I find, but ok, let's keep this as a discussion in imagej-legacy. For this PR, I have a question regarding the following use case: Imagine you have 5 different objects in the object service of a certain class If yes, could we make this modular ? Like can |
53b6733
to
3dc99c9
Compare
This allows to define a way to derive names from objects of third party libraries, e.g. for use in
ObjectService
, where objects are registered with a name and can be provided e.g. in a drop-down choice in the UI.This pull request, together with imagej/imagej-legacy#263, will resolve this forum discussion about being able to automatically populate
ij.measure.ResultsTable
inputs, provided we implement the followingResultsTableNameProvider
in a follow-up pull request toimagej-legacy
:(Suggestions welcome to make this even more concise!)