Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of Bounding Box Context Menus #8059

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Sep 5, 2024

URL of deployed dev instance (used for testing):

Steps to test:

  • Go to bounding box tab within an annotation, have some bounding boxes laying around
  • within the bounding box tab, left and right clicking the three dots aswell as right-clicking a bbox entry (almost) anywhere should open the context menu
  • all enabled actions should be doing something and closing the context menu afterwards
  • the context menu should close when clicking somewhere within the bounding box tab
  • make sure the skeleton tab and the context menus there are looking good and behaving appropriately (minor change there to prevent horizontal scrollbar from showing up)

TODOs:

  • right-clicking the whole bbox list entry should open the context menu (find out how to pass menu there)
  • left-clicking the three dots should open the context menu
  • close context menu after action
  • fix gitch and horizontal scroll bar when opening context menu

(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Sep 5, 2024
@dieknolle3333 dieknolle3333 changed the title move bbox context menus to container Improve performance of Bounding Box Context Menus Sep 5, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review September 17, 2024 15:59
// The parent has a padding of 10px on all sides which we need to subtract here.
width: calc(100% - 20px) !important;
height: calc(100% - 20px) !important;
}

.tree-list-context-menu-overlay{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might fix #8058

Copy link
Member

@hotzenklotz hotzenklotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works well. Thanks. 🚀

@dieknolle3333 dieknolle3333 merged commit d336b7c into master Sep 19, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the bbox-context-menu-perf branch September 19, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants