forked from OpenSourceBrain/243446
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: neuroml conversion #1
Open
sanjayankur31
wants to merge
61
commits into
master
Choose a base branch
from
feat/neuroml-conversion
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move over original files to NEURON folder
We can enable other engines once we have a full cell to test
Requires jNeuroML with these changes so that new annotations are known to LEMS: NeuroML/NeuroML2#225
Note: hard coded
This reverts commit e9561bc.
This reverts commit fb3ab85.
This is taken from https://github.com/OpenSourceBrain/SolinasEtAl-GolgiCell/ where a version already existed. However, a couple of parameters had been tweaked: - diff is 1 instead of 3 - qt10factor is 2.7 instead of 3 I've also copied over the calcium clamp implementations to verify the states. The test script now also inserts calcium if required and plots it. The NML file can probably be simplified a little to unify the rate related component types. I'll look into that later, though.
re-use it from the main gateKS component
Almost there, but O values are smaller than they should be.
So I can compare the current densities
now testing with some calcium clamping
It's used in both CaT and CaP channels.
Note that this channel reads calcium concentration but does not contribute to it, producing a different current density, much like a calcium dependent potassium channel. So, we use a different ion here to distinguish it from the "standard" calcium ion. When using this channel, we need to remember to set this particular ion in the GHK channel density also.
Now we get exact matches to NEURON.
Perhaps not needed, since I have checked all mechs individually in single compartment cells
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: OpenSourceBrain#1 (CI enabled in my repo)