-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added arm support on macOS (M1/M2) #86
base: master
Are you sure you want to change the base?
Conversation
It was tested on a private repository and it is working normally. |
@@ -132,7 +132,7 @@ const runAction = () => { | |||
run( | |||
`${useNpm ? "npx --no-install" : "yarn run"} ${cmd} --${platform} ${ | |||
release ? "--publish always" : "" | |||
} ${args}`, | |||
} ${(platform == "mac") ? "--arm64 --x64" : ""} ${args}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you can configure a universal build as well should this be something that is flagged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually that’s not a bad idea. I’ll look into it…
- Yan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strategy:
matrix:
os: [macos-latest, windows-latest]
arch: ["--x64", "--arm64"]
- name: Build/release Electron app
uses: samuelmeuli/action-electron-builder@v1
with:
args: ${{ matrix.arch }}
No description provided.