Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues around integrating HTTP NIO provider #1689

Open
lbergelson opened this issue Oct 13, 2023 · 0 comments
Open

Resolve issues around integrating HTTP NIO provider #1689

lbergelson opened this issue Oct 13, 2023 · 0 comments

Comments

@lbergelson
Copy link
Member

Trying to add an http nio provider as a test dependency as part of #1688 caused issues because of some deficiencies in the library.

See the test results here

There are 2 failure types:

  1. Not implemented exceptions HtsgetBAMCodecTest because of a missing Path.resolveSibling() method
  2. A failure in SamReaderFactoryTest.testOpenURIFallback() due not falling back for http URLS

example

Gradle suite > Gradle test > htsjdk.beta.codecs.reads.htsget.HtsgetBAM.HtsgetBAMCodecTest > testGetHeader FAILED
    java.lang.UnsupportedOperationException: Not implemented
        at org.broadinstitute.http.nio.HttpPath.resolveSibling(HttpPath.java:362)
        at htsjdk.samtools.SamFiles.lookForIndex(SamFiles.java:71)
        at htsjdk.samtools.SamFiles.findIndex(SamFiles.java:38)
        at htsjdk.beta.plugin.reads.ReadsBundle.resolveIndex(ReadsBundle.java:167)
        at htsjdk.beta.plugin.reads.ReadsBundle.resolveIndex(ReadsBundle.java:147)
        at htsjdk.beta.plugin.registry.ReadsResolver.getReadsDecoder(ReadsResolver.java:73)
        at htsjdk.beta.codecs.reads.htsget.HtsgetBAM.HtsgetBAMCodecTest.testGetHeader(HtsgetBAMCodecTest.java:47)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant