Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strawman attempt at adding array of booleans #537

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yfarjoun
Copy link
Contributor

This is just a first draft, once the wording is finalized, I intend to:

  • modify VCFv4.4 as well
  • add and entry to the change logs

The point of this change is to allow an INFO (or FORMAT) field to contain an arrays of boolean values.

it maintains the old behavior so that a Number of "0" would indicate that the presence of the field is "true" and its absence, "false". but it also allow all the other Number options, and in that case, 0 will indicate "false" while 1 will indicate "true".

@hts-specs-bot
Copy link

Changed PDFs as of e09c519: VCFv4.3 (diff).

@jkbonfield jkbonfield added the vcf label Jan 7, 2021
@d-cameron
Copy link
Contributor

It's a bit unclear on what the values can/should be. I presume an array of 3 booleans would be 0,1,1 with 0=FALSE, 1=TRUE, but the PR should explicitly state that no other values other than 0 or 1 are allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants