Sample ID and filter update #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Modify FILTER header line to add optional Target=<SUBSET of Variant,Genotype, and Sample> Required for Sample filters. |
yfarjoun
changed the title
|
See also htsget PR #430 which ran into some difficulty over the question of whether commas may appear in sample names. |
|
should this modify 4.2 or only 4.3? |
jmarshall
reviewed
Nov 4, 2019
| In the \verb!SAMPLE! line: | ||
| \begin{itemize} | ||
| \item{ID} is a string that identifies the sample. | ||
| It comprises non-whitespace characters and doesn't include the comma (`.') character. |
yfarjoun
commented
Nov 4, 2019
| @@ -240,6 +240,13 @@ \subsubsection{Sample field format} | |||
| ##SAMPLE=<ID=Sample2,Assay=Exome,Ethnicity=CEU,Disease=Cancer,Tissue=Breast,Description="European patient exome from breast cancer"> | |||
There was a problem hiding this comment.
need to add FILTER to the line itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.