Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”§ ECS νƒœμŠ€ν¬ μ •μ˜μ— ν•„μˆ˜ ν™˜κ²½ λ³€μˆ˜ μΆ”κ°€ #67

Merged

Conversation

yuminn-k
Copy link
Contributor

πŸ” 이 PR둜 ν•΄κ²°ν•˜κ³ μž ν•˜λŠ” λ¬Έμ œλŠ” λ¬΄μ—‡μΈκ°€μš”?

  • ECS μ»¨ν…Œμ΄λ„ˆμ—μ„œ μ‹€ν–‰ 쀑인 μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ—μ„œ "ACCESS_TOKEN_SECRET not set" 였λ₯˜κ°€ λ°œμƒν•˜λŠ” 문제λ₯Ό ν•΄κ²°ν•˜κ³ μž ν•©λ‹ˆλ‹€.
  • μΆ”κ°€λ‘œ, λ‹€λ₯Έ ν•„μˆ˜ ν™˜κ²½ λ³€μˆ˜λ“€λ„ λˆ„λ½λ˜μ–΄ μžˆμ–΄ 이λ₯Ό ν•¨κ»˜ μΆ”κ°€ν•˜μ—¬ μœ μ‚¬ν•œ 문제λ₯Ό μ˜ˆλ°©ν•˜κ³ μž ν•©λ‹ˆλ‹€.

✨ 이 PR둜 μ£Όμš”ν•˜κ²Œ 바뀐 점은 λ¬΄μ—‡μΈκ°€μš”?

  • ECS νƒœμŠ€ν¬ μ •μ˜μ— λ‹€μŒ ν™˜κ²½ λ³€μˆ˜λ“€μ„ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€:
    • ACCESS_TOKEN_SECRET
    • REFRESH_TOKEN_SECRET
    • ACCESS_TOKEN_EXPIRY_HOUR
    • REFRESH_TOKEN_EXPIRY_HOUR

πŸ”– μ£Όμš” λ³€κ²½ 사항 외에 μΆ”κ°€λ‘œ λ³€κ²½λœ 뢀뢄이 μžˆλ‚˜μš”?

  • μΆ”κ°€λœ ν™˜κ²½ λ³€μˆ˜λ“€μ΄ λͺ¨λ‘ ν•„μš”ν•œμ§€, ν˜Ήμ‹œ λˆ„λ½λœ ν™˜κ²½ λ³€μˆ˜λŠ” μ—†λŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.
  • ν™˜κ²½ λ³€μˆ˜ 이름이 μ• ν”Œλ¦¬μΌ€μ΄μ…˜ μ½”λ“œμ˜ μ˜ˆμƒκ³Ό μΌμΉ˜ν•˜λŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.

πŸ™πŸ» 리뷰어가 특히 λ΄μ£Όμ—ˆμœΌλ©΄ ν•˜λŠ” 뢀뢄은 λ¬΄μ—‡μΈκ°€μš”?

  • μΆ”κ°€λœ ν™˜κ²½ λ³€μˆ˜λ“€μ΄ λͺ¨λ‘ ν•„μš”ν•œμ§€, ν˜Ήμ‹œ λˆ„λ½λœ ν™˜κ²½ λ³€μˆ˜λŠ” μ—†λŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.
  • ν™˜κ²½ λ³€μˆ˜ 이름이 μ• ν”Œλ¦¬μΌ€μ΄μ…˜ μ½”λ“œμ˜ μ˜ˆμƒκ³Ό μΌμΉ˜ν•˜λŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.

🩺 이 PR둜 ν…ŒμŠ€νŠΈλ‚˜ 검증이 ν•„μš”ν•œ 뢀뢄이 μžˆλ‚˜μš”?

  • ECS μ„œλΉ„μŠ€κ°€ μƒˆλ‘œμš΄ νƒœμŠ€ν¬ μ •μ˜λ‘œ μ •μƒμ μœΌλ‘œ μ—…λ°μ΄νŠΈλ˜λŠ”μ§€ 확인이 ν•„μš”ν•©λ‹ˆλ‹€.
  • μ• ν”Œλ¦¬μΌ€μ΄μ…˜μ΄ μΆ”κ°€λœ ν™˜κ²½ λ³€μˆ˜λ“€μ„ μ •μƒμ μœΌλ‘œ μΈμ‹ν•˜κ³  μ‚¬μš©ν•˜λŠ”μ§€ 확인이 ν•„μš”ν•©λ‹ˆλ‹€.

πŸ“š κ΄€λ ¨λœ Issueλ‚˜ Notion, λ¬Έμ„œ

πŸ–₯ μž‘λ™ν•˜λŠ” λͺ¨μŠ΅

μŠ€ν¬λ¦°μƒ·μ΄λ‚˜ λ…Ήν™”λœ λΉ„λ””μ˜€, λ˜λŠ” gifλ₯Ό μΆ”κ°€ν•΄μ„œ, 리뷰어가 변경점을 μ΄ν•΄ν•˜λŠ” 데 도움이 λ˜λ„λ‘ ν•΄μ£Όμ„Έμš”.

πŸ“Œ PR을 μž‘μ„±ν•  λ•Œμ˜ μ£Όμ˜μ‚¬ν•­

  • λ¦¬λ·°μ–΄λŠ” μ½”λ“œ 리뷰 μ‹œ 쒋은 μ½”λ“œμ˜ λ°©ν–₯성을 μ œμ‹œν•˜μ§€λ§Œ, μ½”λ“œ μˆ˜μ •μ„ κ°•μš”ν•˜μ§€ μ•ŠμŠ΅λ‹ˆλ‹€.
  • λ¦¬λ·°μ–΄λŠ” 쒋은 μ½”λ“œλ₯Ό λ°œκ²¬ν•˜λ©΄ μΉ­μ°¬κ³Ό 격렀λ₯Ό 아끼지 μ•ŠμŠ΅λ‹ˆλ‹€.
  • λ¦¬λ·°λŠ” νŠΉλ³„ν•œ κ²½μš°κ°€ μ•„λ‹ˆλΌλ©΄, λ¦¬λ·°μ–΄λ‘œ μ§€μ •λœ μ‹œμ λΆ€ν„° 3일 이내에 μ™„λ£Œν•΄μ£Όμ„Έμš”.
  • λŒ“κΈ€ μž‘μ„± μ‹œ Prefix에 P1, P2, P3을 μž‘μ„±ν•΄μ£Όμ‹œλ©΄, λ‹΄λ‹Ήμžκ°€ λŒ“κΈ€μ— λŒ€ν•΄ 더 λͺ…ν™•νžˆ λŒ€μ‘ν•  수 μžˆμŠ΅λ‹ˆλ‹€.
    • P1 : λ°˜λ“œμ‹œ λ°˜μ˜ν•΄μ£Όμ„Έμš” (Request Changes) - λ¬Έμ œκ°€ λ°œμƒν•˜κ±°λ‚˜, 취약점이 발견된 경우 λ“±.
    • P2 : λ°˜μ˜μ„ 적극적으둜 κ²€ν† ν•΄μ£Όμ„Έμš” (λŒ“κΈ€).
    • P3 : 이런 방법도 μžˆμ„ 것 κ°™λ‹€λŠ” μ‚¬μ†Œν•œ μ˜κ²¬μž…λ‹ˆλ‹€ (Chore).

…bles

- Add ACCESS_TOKEN_SECRET to ECS task definition
- Add REFRESH_TOKEN_SECRET to ECS task definition
- Add ACCESS_TOKEN_EXPIRY_HOUR to ECS task definition
- Add REFRESH_TOKEN_EXPIRY_HOUR to ECS task definition

This change ensures that all necessary environment variables are
available to the application running in the ECS container, fixing
the "ACCESS_TOKEN_SECRET not set" error and potentially preventing
similar issues with other required variables.

Related to ryokushaka#37
@yuminn-k yuminn-k added ⏰ P0 λ°˜λ“œμ‹œ ν•΄κ²°ν•΄μ•Ό ν•˜λŠ” μ€‘μš”ν•œ μ΄μŠˆλ‚˜ 문제 (예: 버그, 취약점 λ“±) 🐞 BugFix Something isn't working πŸ†— safe CI workflow λ™μž‘ κ΄€λ ¨ 🌏 Deploy 배포 κ΄€λ ¨ labels Oct 14, 2024
@yuminn-k yuminn-k self-assigned this Oct 14, 2024
@yuminn-k yuminn-k merged commit fd41d37 into ryokushaka:main Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 BugFix Something isn't working 🌏 Deploy 배포 κ΄€λ ¨ ⏰ P0 λ°˜λ“œμ‹œ ν•΄κ²°ν•΄μ•Ό ν•˜λŠ” μ€‘μš”ν•œ μ΄μŠˆλ‚˜ 문제 (예: 버그, 취약점 λ“±) πŸ†— safe CI workflow λ™μž‘ κ΄€λ ¨
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant