Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the UnwindSafe/RefUnwindSafe traits on channels #2772

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Implement the UnwindSafe/RefUnwindSafe traits on channels #2772

wants to merge 1 commit into from

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Sep 9, 2023

To my surprise, this trait isn't implemented on channels, even though channels are kind of a critical component to unwind safety.

See the code comment for an explanation of the reasoning.

I'm not 100% confident in what I'm doing, so feel free to summon unwind-safety experts, if there is any.

@taiki-e
Copy link
Member

taiki-e commented Sep 10, 2023 •
edited
Loading

Thanks for the PR. I think we should make AtomicWaker UnwindSafe (#2211) first. (like tokio did)

@taiki-e taiki-e added the A-channel Area: futures::channel label Sep 10, 2023
@thomaseizinger thomaseizinger mentioned this pull request Oct 14, 2023
Merged
4 tasks
@taiki-e taiki-e added the S-blocked Status: Blocked on something else label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-channel Area: futures::channel S-blocked Status: Blocked on something else
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomaka @taiki-e