Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow range be Float #905

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow range be Float #905

wants to merge 2 commits into from

Conversation

artyomb
Copy link

@artyomb artyomb commented Sep 5, 2023

#904 (comment)

As described in https://docs.swagger.io/spec.html

minimum | string | number, integer | The minimum valid value for the type, inclusive. If this field is used in conjunction with the defaultValue field, then the default value MUST be higher than or equal to this value. The value type is string and should represent the minimum numeric value. Note: This will change to a numeric value in the future.

The values may be number (float or double)?

@LeFnord
Copy link
Member

LeFnord commented Sep 6, 2023

@artyomb … yeah, makes sense to allow any kind of number

please rebase against master, it fixes the rubocop stuff

@artyomb
Copy link
Author

artyomb commented Sep 6, 2023

Sorry, if I broke something. I don't know how to rebase with this pull request.

@artyomb
Copy link
Author

artyomb commented Sep 18, 2023

I did "sync fork". Hope it helped?

@LeFnord
Copy link
Member

LeFnord commented Nov 13, 2023

no … please have a look on the failures, it seems your change is related to it

@artyomb
Copy link
Author

artyomb commented Nov 13, 2023

Ok, sorry. I don't know how complete the request. Please close/reject it. Maybe move to the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants