Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_route_visibility to Defaults #888

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add default_route_visibility to Defaults #888

wants to merge 5 commits into from

Conversation

dmoss18
Copy link
Contributor

@dmoss18 dmoss18 commented Feb 14, 2023

No description provided.

@LeFnord
Copy link
Member

LeFnord commented Feb 15, 2023

thanks @dmoss18 … please can you quikcly fix the rubucop stuff

@dmoss18
Copy link
Contributor Author

dmoss18 commented Feb 15, 2023

@LeFnord Rubocop updated, but the head ruby tests failed while setting up ruby

@LeFnord
Copy link
Member

LeFnord commented Feb 19, 2023

@dmoss18 … I updated the CI matrix … please have a look at the actual failures, thanks

@LeFnord
Copy link
Member

LeFnord commented Apr 7, 2023 •
edited
Loading

one question, does the hiding of a route still work?

mean do we have breaking changes with it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmoss18 @LeFnord