-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement BridgeStan download and module compilation on Rust #212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this on! A few thoughts on what is here so far
okay, all done |
You may have to skip some of the compile tests on Windows for Rust, since we never unload libraries (#111) and Windows locks the file of loaded libraries |
i see, what about Mac? it seems to give some weird error that is hard to understand, seems to be C++ toolchain related. |
I’ll try to take a look this week - my guess is it has to do with the specific CI environment installing a non-native LLVM |
4fa508f
to
ebb8e81
Compare
de7456e
to
8e7f8a6
Compare
there also seems to be some toolchain problem on Windows, lack of mingw, so it's unable to compile the example. |
8be81b7
to
6fb0bf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. A few more comments below.
I'm also going to ask @aseyboldt if he would be willing to take a look at this
6240094
to
89373cf
Compare
finally managed to fix the build on macos now! |
@WardBrian @aseyboldt made the API a little more clear now regarding that bridgestan is being download, and also easier to point to a custom bridgestan dir. I think that the checksum and the lock dir would be better fit as others issues/PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following are hopefully my final comments, focusing on some edge cases in the example and tests.
I'd still like @aseyboldt do give another look over for any Rust nits I'm missing. But I think this is very good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I left two tiny questions about the tests, and I would still appreciate if @aseyboldt could have a look before merging.
Thanks again!
Implement BridgeStan download and module compilation on Rust.
Fixes issue #100