Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template in Spanish #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maurolepore
Copy link
Member

Follow up #468


@maelle
Copy link
Member

maelle commented Nov 1, 2021

@xuanxu At the moment we have one template in Spanish (review). When adding a new template in Spanish like in this PR what do we need to do to ensure it'll be used by buffy? Thank you!

@xuanxu
Copy link
Collaborator

xuanxu commented Nov 2, 2021

If the template is located in .buffy/templates then Buffy can find it. It can be used by name in the configuration of any responder.

@maelle
Copy link
Member

maelle commented Nov 2, 2021

Thanks! I think my question is then, how do we make buffy multilingual? :-)

  • If the submission is in English, use the template without language code.
  • If it is in Spanish, use the template with "es" or fall back on the template without language code.

It's a bigger feature request than I realized yesterday, and can't remember where we had previously discussed it.

@xuanxu
Copy link
Collaborator

xuanxu commented Nov 2, 2021

Oh right. I agree it is a bigger feature.
Right now how do we know the language a submission is in? Is there a mark/variable in the body of the issue? I guess once we have that, we could try to append it to the template name. We would have to define a template naming convention based in file names or folders.

@maelle
Copy link
Member

maelle commented Nov 2, 2021

@xuanxu
Copy link
Collaborator

xuanxu commented Nov 2, 2021

Yes, I think first step to multilang is to have something like language-code: es/en in the templates

@noamross noamross added the meta label Aug 18, 2022
@maurolepore
Copy link
Member Author

Oh, just now noticing this has been sitting here for a long time :-)
@maelle do you think this is still useful?

@maelle
Copy link
Member

maelle commented Feb 27, 2023

@maurolepore it is but still not usable because of missing features in buffy. Thanks for checking!

@maurolepore
Copy link
Member Author

@maelle I see this is pretty old. Can I close it?

@maelle
Copy link
Member

maelle commented May 28, 2024

as you prefer! cc @mpadge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants