forked from vitejs/vite
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using Rolldown with Vite v6 #43
Draft
sapphi-red
wants to merge
15
commits into
main
Choose a base branch
from
rolldown-v6
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sapphi-red
force-pushed
the
rolldown-v6
branch
4 times, most recently
from
September 18, 2024 06:41
f2a0e05
to
3cbc479
Compare
Co-authored-by: underfin <[email protected]>
sapphi-red
force-pushed
the
rolldown-v6
branch
from
September 18, 2024 06:44
3cbc479
to
8373fce
Compare
Co-authored-by: underfin <[email protected]>
Co-authored-by: underfin <[email protected]>
Co-authored-by: underfin <[email protected]>
sapphi-red
force-pushed
the
rolldown-v6
branch
4 times, most recently
from
September 18, 2024 09:09
0561e91
to
1d231ee
Compare
2cf0eb2 fe71cbc Co-authored-by: IWANABETHATGUY <[email protected]>
Co-authored-by: IWANABETHATGUY <[email protected]>
sapphi-red
force-pushed
the
rolldown-v6
branch
from
September 18, 2024 09:15
1d231ee
to
2087832
Compare
sapphi-red
force-pushed
the
rolldown-v6
branch
from
September 19, 2024 09:23
259bd2a
to
6af67ee
Compare
FYI,
this is by design, if use customResolver in native plugin, there is no performance difference between |
for all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Applied changes from #24 and #27 to the main branch after the environment API PR is merged.
Also fixed errors on Windows and cleaned up some unneeded changes.
#24 implemented build-time dep optimization partially, but I didn't include that change in this PR.
e2e test status
-rolldown/rolldown#2031
- using Array input generate name is not expected, the entry name will be like index~1.js
missing feature list that was supported by esbuild / rollup
options.watch
watcher.on('event', listener)
shouldTransformCachedModule
,watchChange
,closeWatcher
this.addWatchFile
meta
on module info: this can be workarounded as it's not part of the public APIumd
formatsystem
formatoutput
is currently an object instead of an arrayoptions.attributes
forresolveId
hookSourceMap
type does not supporttoString
andtoUrl
: not necessary but better for easier migrationresolveImportMeta
hook: can usetransform
hook for Vite's usecaseoptions.preserveEntrySignatures
: not necessary but nice for smaller bundlesimprovements needed later on Vite side
optimizeDeps.esbuildOptions
intooptimizeDeps.rollupOptions
automatically if possiblenative plugin incompatibilities
customResolver
optionRESOLVED_MODULE_PRELOAD_POLYFILL_ID
rolldown#2261)Rolldown internal error: expected value at line 1 column 1
, probably the builtin one is not working? https://github.com/rolldown/rolldown/blob/12293fac6b80307959bd34775bde8e2f5dd2e744/crates/rolldown_plugin_json/src/lib.rs#L43./**.js
(**
not ending with/
).replaceAll('\\', '/')
on the resolved idTODO list for me
!~{003}~
https://github.com/vitejs/vite/blob/main/docs/guide/backend-integration.md#:~:text=%22_shared%2D!~%7B003%7D~.js%22%3A%20%7BnativeBuildImportAnalysisPlugin
option: f92519b#diff-121079017d1fa98d6a0ea3354d5c73df45ab277078228cd7384c7a4e84c5a813R182this.environment
inoptions
hook: d1f1aaf