Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor docs and help text improvements #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

josharian
Copy link
Contributor

I'm happy to leave off the last commit if you prefer. I really only meant to send the first commit, but kept noticing stuff. :)

Before:

$ gohack help get
[snip]
It uses $GOHACK/<module> as the destination directory,
or $HOME/gohack/<module> if $GOHACK is empty.
[snip]

No need to escape html entities for the terminal. :)
Since -u hasn't been implemented yet,
we shouldn't advertise it in the help text.
Subcommands have been introduced.
They don't perfectly match this structure,
but it is reasonably close.
The TODO comment contains a few as-yet unimplemented
ideas for other features and subcommands:

* get -u already has a todo in the get flags
* rm isn't implemented, but it is also not likely to be forgotten if/when it is needed
* dir has lots of overlap with rogpeppe#61, and the issue tracker is a better place to discuss

Given that, the outdated comment no longer pulls its weight. Cull it.
@myitcv
Copy link
Collaborator

myitcv commented Dec 14, 2019

cc @rogpeppe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants