Merge pull request #93 from rhettre/bugfix/error-response

Bugfix/error response
rhettre · Sep 6, 2024 · 3c4f8cc · 3c4f8cc
2 parents 0eb7a86 + 3856c40
commit 3c4f8cc
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/coinbase_advanced_trader/legacy_tests/test_coinbase_client.py b/coinbase_advanced_trader/legacy_tests/test_coinbase_client.py
@@ -189,7 +189,7 @@ def test_cancel_orders(self, mock_cb_auth):
         self.assertTrue(results['success'])
         self.assertEqual(results['failure_reason'],
                          "UNKNOWN_CANCEL_FAILURE_REASON")
-        self.assertEqual(results['order_id'], "0000-00000")
+        self.assertEqual(results['success_response']['order_id'], "0000-00000")
 
     @patch('coinbase_advanced_trader.coinbase_client.cb_auth')
     def test_list_orders(self, mock_cb_auth):
@@ -341,7 +341,7 @@ def test_get_order(self, mock_cb_auth):
         self.assertIsNotNone(result)
         self.assertIsInstance(result, dict)
         self.assertIn('order', result)
-        self.assertEqual(result['order']['order_id'], order_id)
+        self.assertEqual(result['order']['success_response']['order_id'], order_id)
         self.assertEqual(result['order']['product_id'], 'BTC-USD')
         self.assertEqual(result['order']['status'], 'OPEN')
 

diff --git a/coinbase_advanced_trader/services/order_service.py b/coinbase_advanced_trader/services/order_service.py
@@ -62,7 +62,7 @@ def fiat_market_buy(self, product_id: str, fiat_amount: str) -> Order:
                 raise Exception(error_log)
 
             order = Order(
-                id=order_response['order_id'],
+                id=order_response['success_response']['order_id'],
                 product_id=product_id,
                 side=OrderSide.BUY,
                 type=OrderType.MARKET,
@@ -113,7 +113,7 @@ def fiat_market_sell(self, product_id: str, fiat_amount: str) -> Order:
                 raise Exception(error_log)
 
             order = Order(
-                id=order_response['order_id'],
+                id=order_response['success_response']['order_id'],
                 product_id=product_id,
                 side=OrderSide.SELL,
                 type=OrderType.MARKET,
@@ -198,7 +198,7 @@ def _place_limit_order(self, product_id: str, fiat_amount: str, limit_price: Opt
         )
 
         order = Order(
-            id=order_response['order_id'],
+            id=order_response['success_response']['order_id'],
             product_id=product_id,
             side=side,
             type=OrderType.LIMIT,

diff --git a/setup.py b/setup.py
@@ -8,7 +8,7 @@
 
 setup(
     name='coinbase-advancedtrade-python',
-    version='0.2.4',
+    version='0.2.5',
     description='The unofficial Python client for the Coinbase Advanced Trade API',
     long_description=long_description,
     long_description_content_type="text/markdown",